Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve regex for Email #271

Merged
merged 7 commits into from
Nov 2, 2020
Merged

Improve regex for Email #271

merged 7 commits into from
Nov 2, 2020

Conversation

siangernlow
Copy link

Regex for email format has been improved to fix issues in #254

Resolve #254
Resolve #270

@siangernlow siangernlow added bug Something isn't working enhancement New feature or request priority.High Needs to be completed soon Implementation Coding required labels Nov 1, 2020
@siangernlow siangernlow added this to the v1.4 milestone Nov 1, 2020
@siangernlow siangernlow self-assigned this Nov 1, 2020
@codecov-io
Copy link

codecov-io commented Nov 1, 2020 •
edited

Codecov Report

Merging #271 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #271   +/-   ##
=========================================
  Coverage     83.89%   83.89%           
  Complexity     1121     1121           
=========================================
  Files           127      127           
  Lines          3037     3037           
  Branches        402      402           
=========================================
  Hits           2548     2548           
  Misses          401      401           
  Partials         88       88
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/model/attribute/Email.java 90.00% <ø> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c56274...4182308. Read the comment docs.

hopinxian
hopinxian requested changes Nov 2, 2020
View reviewed changes
Copy link

@hopinxian hopinxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small update required for the User guide. Otherwise LGTM

src/main/java/seedu/address/model/attribute/Email.java Show resolved Hide resolved
@hopinxian hopinxian merged commit 0f5a922 into AY2021S1-CS2103T-T13-1:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopinxian hopinxian hopinxian approved these changes

Assignees

@siangernlow siangernlow

Labels
bug Something isn't working enhancement New feature or request Implementation Coding required priority.High Needs to be completed soon
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Improve regex for Email [PE-D] Email field can contain illegal format
3 participants
@siangernlow @codecov-io @hopinxian