Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UG and DG #291

Merged
merged 13 commits into from
Nov 7, 2020
Merged

Update UG and DG #291

merged 13 commits into from
Nov 7, 2020

Conversation

siangernlow
Copy link

  1. Diagrams of the DG have to be updated.
  2. CSV related sections have to be updated.
  3. Miscellaneous sections should be updated.

@siangernlow siangernlow added bug Something isn't working documentation Improvements or additions to documentation User Guide Developer Guide labels Nov 7, 2020
@siangernlow siangernlow added this to the v1.4 milestone Nov 7, 2020
@siangernlow siangernlow self-assigned this Nov 7, 2020
@siangernlow
Copy link
Author

As of this commit, DG has been updated. Future commits would be for UG unless stated otherwise.

@siangernlow siangernlow marked this pull request as ready for review November 7, 2020 07:07
@siangernlow
Copy link
Author

UG has been updated

@siangernlow
Merge branch 'master' into v1.4/branch-UG
9a65bb8
@siangernlow
Merge branch 'master' into v1.4/branch-UG
4216632
@siangernlow
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T13-1/tp …
0d2ce4b 
…into v1.4/branch-UG

# Conflicts:
#	docs/DeveloperGuide.md
#	docs/UserGuide.md
#	docs/diagrams/ArchitectureSequenceDiagram.puml
#	docs/diagrams/DeleteSequenceDiagram.puml
#	docs/diagrams/StorageClassDiagram.puml
#	docs/diagrams/UiClassDiagram.puml
#	docs/images/ArchitectureSequenceDiagram.png
#	docs/images/LogicClassDiagram.png
#	docs/images/StorageClassDiagram.png
#	docs/images/UiClassDiagram.png
@siangernlow
Add newline at EOF
3ae31b9
@codecov-io
Copy link

Codecov Report

Merging #291 (3ae31b9) into master (505c6f2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #291   +/-   ##
=========================================
  Coverage     83.88%   83.88%           
  Complexity     1126     1126           
=========================================
  Files           125      125           
  Lines          3028     3028           
  Branches        410      410           
=========================================
  Hits           2540     2540           
  Misses          393      393           
  Partials         95       95
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 100.00% <100.00%> (ø) 13.00 <0.00> (ø)
...a/seedu/address/storage/JsonPersonBookStorage.java 100.00% <100.00%> (ø) 8.00 <1.00> (ø)
...ain/java/seedu/address/storage/StorageManager.java 100.00% <100.00%> (ø) 20.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505c6f2...3ae31b9. Read the comment docs.

KohHanMing
KohHanMing approved these changes Nov 7, 2020
View reviewed changes
Copy link
Collaborator

@KohHanMing KohHanMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KohHanMing KohHanMing merged commit d2b2fe9 into AY2021S1-CS2103T-T13-1:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KohHanMing KohHanMing KohHanMing approved these changes

Assignees

@siangernlow siangernlow

Labels
bug Something isn't working Developer Guide documentation Improvements or additions to documentation User Guide
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siangernlow @codecov-io @KohHanMing