Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issues of UC01 and UC02 and add new extensions #53

Closed

Conversation

DreamerDragon
Copy link

Resolves #51

@siangernlow siangernlow changed the title fix formatting issues of UC01 and UC02 and add new extensions Fix formatting issues of UC01 and UC02 and add new extensions Sep 26, 2020
Copy link

@siangernlow siangernlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. Just some minor rephrasing as suggested. Otherwise, LGTM


**MSS**

1. User chooses to add a visit to the visits history list.
2. VirusTracker requests for details of the visit in a specific format.
3. User enters the required details (Person, Date, Location).
3. User enters the required details (PersonId, LocationId, Date).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this, it could just be "User enters the required details" since implementation/UI details are not needed for use cases.

2c.1 User enters “Cancel”
2c.2 VirusTracker acknowledges and returns user to main page
* 2d. User wishes to cancel the add command
2d.1 User enters “Cancel”

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Perhaps you could try "User requests to cancel the command" instead?


* 2b. The locationId is invalid.

2b.1 VirusTracker prompts user for correct locationId

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe bullet points are required for indentation here as well.

@DreamerDragon DreamerDragon deleted the Branch_DG branch September 27, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DG]Fix formatting issue of UC01 and UC02 and update the content
2 participants