Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to add locations #69

Merged
merged 17 commits into from
Sep 27, 2020
Merged

Add functionality to add locations #69

merged 17 commits into from
Sep 27, 2020

Conversation

hopinxian
Copy link

@hopinxian hopinxian commented Sep 27, 2020

Location models has been added. A locationBook is created to store manage locations, similar to how addressBook manages people. Virus tracker is now able to store and read a list of locations. Test cases have also been made to cover the functionality involved in storing, reading and adding locations.

Close #56

Create an Add Location command for adding locations.
Errors exist because underlying model is not created.
No test classes created yet.
Model and ModelManager have been updated to handle
locations. They are now able to manage a LocationBook
together with a AddressBook.

Errors still exist since LocationBook class has not
been created.
ReadOnlyLocationBook presents an interface for read only
functions. LocationBook serves as a wrapper class for
managing a list of locations.

Errors still exist due to lack of model classes.
No test classes created yet.

Extra methods involving deletion, editing of locations were
made. They are foreseen to be necessary in the adding of future
features involving deletion and editing of locations.
A unique location list is added to ensure no duplicates
in locations. Exceptions were created to handle conflicts
when a duplicate location is given or a location is not
found.

Extra methods involving deletion, editing of locations were
made. They are foreseen to be necessary in the adding of future
features involving deletion and editing of locations.
Location unit class relies on the address and name class
used in person class.
Exception classes updated to pass checkstyle.
Sample locations data has been added.
Virus tracker is able to read in a list of locations
and store a list of locations.

No test cases are added.
@hopinxian hopinxian changed the title Branch add locations Add functionality to add locations Sep 27, 2020
@hopinxian hopinxian marked this pull request as ready for review September 27, 2020 11:36
@hopinxian hopinxian added this to the v1.1 milestone Sep 27, 2020
@hopinxian hopinxian added Implementation Coding required priority.High Needs to be completed soon labels Sep 27, 2020
Copy link

@siangernlow siangernlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hopinxian and others added 3 commits September 27, 2020 22:59
…into branch-AddLocations

# Conflicts:
#	src/main/java/seedu/address/model/Location.java
#	src/main/java/seedu/address/model/Model.java
#	src/test/java/seedu/address/logic/commands/AddCommandTest.java
Copy link

@hhdqirui hhdqirui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hopinxian hopinxian merged commit 664d29f into AY2021S1-CS2103T-T13-1:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Coding required priority.High Needs to be completed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement functionality to add locations
3 participants