forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to add locations #69
Merged
hopinxian
merged 17 commits into
AY2021S1-CS2103T-T13-1:master
from
hopinxian:branch-AddLocations
Sep 27, 2020
Merged
Add functionality to add locations #69
hopinxian
merged 17 commits into
AY2021S1-CS2103T-T13-1:master
from
hopinxian:branch-AddLocations
Sep 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create an Add Location command for adding locations. Errors exist because underlying model is not created. No test classes created yet.
Model and ModelManager have been updated to handle locations. They are now able to manage a LocationBook together with a AddressBook. Errors still exist since LocationBook class has not been created.
ReadOnlyLocationBook presents an interface for read only functions. LocationBook serves as a wrapper class for managing a list of locations. Errors still exist due to lack of model classes. No test classes created yet. Extra methods involving deletion, editing of locations were made. They are foreseen to be necessary in the adding of future features involving deletion and editing of locations.
A unique location list is added to ensure no duplicates in locations. Exceptions were created to handle conflicts when a duplicate location is given or a location is not found. Extra methods involving deletion, editing of locations were made. They are foreseen to be necessary in the adding of future features involving deletion and editing of locations.
Location unit class relies on the address and name class used in person class.
Exception classes updated to pass checkstyle.
Sample locations data has been added. Virus tracker is able to read in a list of locations and store a list of locations. No test cases are added.
hopinxian
added
Implementation
Coding required
priority.High
Needs to be completed soon
labels
Sep 27, 2020
siangernlow
approved these changes
Sep 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…into branch-AddLocations # Conflicts: # src/main/java/seedu/address/model/Location.java # src/main/java/seedu/address/model/Model.java # src/test/java/seedu/address/logic/commands/AddCommandTest.java
…into branch-AddLocations
hhdqirui
approved these changes
Sep 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location models has been added. A locationBook is created to store manage locations, similar to how addressBook manages people. Virus tracker is now able to store and read a list of locations. Test cases have also been made to cover the functionality involved in storing, reading and adding locations.
Close #56