Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionList title bug #138

Merged
merged 12 commits into from
Oct 18, 2020
Merged

Conversation

maguireong
Copy link

No description provided.

@maguireong maguireong added the status.ToReview PR ready for review label Oct 17, 2020
@maguireong maguireong added this to the v1.3 milestone Oct 17, 2020
@maguireong maguireong self-assigned this Oct 17, 2020
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #138 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #138      +/-   ##
============================================
- Coverage     67.45%   67.33%   -0.12%     
  Complexity      672      672              
============================================
  Files           105      105              
  Lines          2338     2342       +4     
  Branches        267      268       +1     
============================================
  Hits           1577     1577              
- Misses          664      668       +4     
  Partials         97       97              
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/RightSideBar.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295a11a...595797f. Read the comment docs.

@kelvinvin
Copy link

image
Still updates the title regardless of the command
e.g. cadd n/Johnny p/12112 e/awpind@gmail.com a/tekong.

I think we can check whether commandResult == CommandResult(MESSAGE_SHOW_SESSIONS_SUCCESS) before updating the title

Copy link

@tanweijie123 tanweijie123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

private String requiredPeriod(CommandResult commandResult, String commandText) {
if (commandResult.getFeedbackToUser().equals(ViewSessionCommand.MESSAGE_SHOW_SESSIONS_SUCCESS)
&& commandText.contains(PREFIX_PERIOD.toString())) {
System.out.println(commandResult.getFeedbackToUser());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to remove debug statement before merging
System.out.println(commandResult.getFeedbackToUser());

@maguireong maguireong merged commit e7206b2 into AY2021S1-CS2103T-T13-3:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status.ToReview PR ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants