Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change isUnique to isIdentical #166

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Change isUnique to isIdentical #166

merged 2 commits into from
Oct 28, 2020

Conversation

dhafinrazaq
Copy link

@dhafinrazaq dhafinrazaq commented Oct 27, 2020

Better to be merged in 1.4 (along with other code quality fixes)

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     65.24%   65.24%           
  Complexity      768      768           
=========================================
  Files           110      110           
  Lines          2693     2693           
  Branches        300      300           
=========================================
  Hits           1757     1757           
  Misses          827      827           
  Partials        109      109           
Impacted Files Coverage Δ Complexity Δ
...ess/logic/commands/session/EditSessionCommand.java 91.22% <0.00%> (ø) 11.00 <0.00> (ø)
...c/main/java/seedu/address/model/client/Client.java 95.00% <ø> (ø) 19.00 <0.00> (ø)
...in/java/seedu/address/model/schedule/Schedule.java 84.44% <ø> (ø) 23.00 <0.00> (ø)
...main/java/seedu/address/model/session/Session.java 97.36% <ø> (ø) 18.00 <0.00> (ø)
src/main/java/seedu/address/ui/ClientInfoPage.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/Homepage.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 76.77% <66.66%> (ø) 47.00 <1.00> (ø)
...dress/logic/commands/client/EditClientCommand.java 90.54% <100.00%> (ø) 12.00 <0.00> (ø)
...s/logic/commands/schedule/EditScheduleCommand.java 83.69% <100.00%> (ø) 13.00 <0.00> (ø)
src/main/java/seedu/address/model/UniqueList.java 93.61% <100.00%> (ø) 24.00 <1.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3caab57...cf80904. Read the comment docs.

@dhafinrazaq dhafinrazaq marked this pull request as draft October 28, 2020 12:13
@dhafinrazaq dhafinrazaq marked this pull request as ready for review October 28, 2020 14:44
Copy link

@benclmnt benclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@benclmnt benclmnt merged commit dabb54f into master Oct 28, 2020
@benclmnt benclmnt deleted the br-isUnique branch October 28, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants