Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit session functionality #83

Closed

Conversation

maguireong
Copy link

Require some help in EditSessionCommandParserTest, 3 assertions in 1 of the method doesn't work quite right yet. Other than that, everything works fine.

@maguireong maguireong added status.needHelp Extra attention is needed status.ToReview PR ready for review labels Oct 4, 2020
@maguireong maguireong added this to the v1.2 milestone Oct 4, 2020
@maguireong maguireong self-assigned this Oct 4, 2020
@maguireong maguireong linked an issue Oct 4, 2020 that may be closed by this pull request
@benclmnt
Copy link

benclmnt commented Oct 5, 2020

Btw, perhaps it is better to test for checkstyle locally before pushing?

To run checkstyle and test cases, run ./gradlew check from Intellij terminal

To edit your last commit (so as to clutter the commit history), do git commit --amend --no-edit (also in terminal)

…ession-branch

# Conflicts:
#	src/main/java/seedu/address/logic/parser/AddressBookParser.java
@maguireong maguireong removed the status.needHelp Extra attention is needed label Oct 5, 2020
Copy link

@benclmnt benclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a huge chunk commented out in EditSessionCommandTest.java

Are we going to need it? If not, perhaps it is better to remove it first and create a new Issue for this.

Other changes look sensible to me

@maguireong
Copy link
Author

maguireong commented Oct 6, 2020

There's a huge chunk commented out in EditSessionCommandTest.java

Are we going to need it? If not, perhaps it is better to remove it first and create a new Issue for this.

Other changes look sensible to me

That's for future tests because it requires the find session function for it to work, that's why I commented it out for now

@maguireong maguireong closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status.ToReview PR ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a trainer, I can edit session details
3 participants