Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete session command #97

Merged
merged 5 commits into from
Oct 12, 2020
Merged

Delete session command #97

merged 5 commits into from
Oct 12, 2020

Conversation

benclmnt
Copy link

@benclmnt benclmnt commented Oct 11, 2020 •
edited

Closes #36

Add implementation + tests for DeleteSessionCommand similar to DeleteClientCommand

Keyword: sdel

Notes:

@benclmnt benclmnt self-assigned this Oct 11, 2020
@benclmnt benclmnt added the status.ToReview PR ready for review label Oct 11, 2020
@benclmnt benclmnt added this to the v1.2b milestone Oct 11, 2020
maguireong
maguireong approved these changes Oct 12, 2020
View reviewed changes
Copy link

@maguireong maguireong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, lgtm

src/test/java/seedu/address/logic/commands/session/DeleteSessionCommandTest.java Outdated Show resolved Hide resolved
@benclmnt benclmnt merged commit 7568adc into AY2021S1-CS2103T-T13-3:master Oct 12, 2020
@benclmnt benclmnt deleted the delete-session branch October 12, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maguireong maguireong maguireong approved these changes

Assignees

@benclmnt benclmnt

Labels
status.ToReview PR ready for review
Projects
None yet
Milestone
v1.2b
Development

Successfully merging this pull request may close these issues.

As a trainer, I can remove session
2 participants
@benclmnt @maguireong