Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit and tests for Amount #148

Merged

Conversation

jordanyoong
Copy link

Limit Amount to have a value of not more than 1000000.00

@codecov-io
Copy link

Codecov Report

Merging #148 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
+ Coverage     55.02%   55.09%   +0.07%     
- Complexity      426      428       +2     
============================================
  Files            96       96              
  Lines          1772     1775       +3     
  Branches        194      195       +1     
============================================
+ Hits            975      978       +3     
  Misses          722      722              
  Partials         75       75              
Impacted Files Coverage Δ Complexity Δ
...java/seedu/address/model/account/entry/Amount.java 71.42% <100.00%> (+7.79%) 6.00 <3.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32d44b...c0c20f1. Read the comment docs.

Copy link

@Ziyang-98 Ziyang-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ziyang-98 Ziyang-98 merged commit 0926c1d into AY2021S1-CS2103T-T13-4:master Oct 23, 2020
@Ziyang-98 Ziyang-98 linked an issue Oct 24, 2020 that may be closed by this pull request
@Ziyang-98 Ziyang-98 added this to the v1.3b (2nd sprint) milestone Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exception handling - Implement limit to Amount
3 participants