-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undo command #149
Add undo command #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
============================================
- Coverage 52.80% 52.53% -0.27%
- Complexity 428 431 +3
============================================
Files 97 98 +1
Lines 1854 1892 +38
Branches 202 204 +2
============================================
+ Hits 979 994 +15
- Misses 800 819 +19
- Partials 75 79 +4
Continue to review full report at Codecov.
|
I add new method to Account so that GetTotalCommand and GetProfitCommand's code quality is improved. I added assertions to all the Commands as well. Lastly, I implemented the UndoCommand. I only allow UndoCommand for editing, deleting and adding of entries. Also, if the user switches account, the user will not be able to undo the previous commands even if the user switches back.