Refactor add command parser #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Test, add Category, move parser utils method to package "util" in parser, delete addressbook commands except add, delete and help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored AddCommandParser, so now just need to refactor AddCommand to integrate with the parser. I have also refactored ParserUtils, ParserUtils test and added a new class Category under parser which is to determine whether an entry to be added is a revenue or an expense. Also, I moved all the parser util classes to a util package under parser package. Lastly, I deleted the addressnbook commands except Add, Delete and Help Command.
Additional Notes: While the AddCommandParser checks and create a Revenue/Expense based on category, the AddCommand should check whether the entry is of type Revenue/Expense so that it can be added to the correct list respectively.