Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Gender.value from string to enum #159

Merged

Conversation

nicktohzyu
Copy link

couldn't get enum.toString to work, so for jsonification I changed Gender.value to Gender.toString (wanted Gender.value.toString)

couldn't get enum.toString to work, so for jsonification I changed Gender.value to Gender.toString (wanted Gender.value.toString)
@nicktohzyu
Copy link
Author

closes #128

@codecov-io
Copy link

Codecov Report

Merging #159 into master will increase coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #159      +/-   ##
============================================
+ Coverage     26.47%   26.57%   +0.10%     
- Complexity      290      291       +1     
============================================
  Files           125      125              
  Lines          2312     2322      +10     
  Branches        276      277       +1     
============================================
+ Hits            612      617       +5     
- Misses         1661     1665       +4     
- Partials         39       40       +1     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/storage/JsonAdaptedClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../seedu/address/storage/JsonAdaptedHairdresser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../main/java/seedu/address/ui/client/ClientCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../seedu/address/ui/hairdresser/HairdresserCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/model/person/Gender.java 63.63% <62.50%> (-11.37%) 7.00 <2.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f09744...3d42669. Read the comment docs.

@zyifanz
Copy link

zyifanz commented Oct 19, 2020

LGTM!

@zyifanz zyifanz merged commit f50dfff into AY2021S1-CS2103T-T15-1:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants