Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for shortcuts #262

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

pooty3
Copy link

@pooty3 pooty3 commented Nov 5, 2020

No description provided.

@pooty3 pooty3 added this to the v1.4 milestone Nov 5, 2020
@pooty3 pooty3 self-assigned this Nov 5, 2020
@pooty3 pooty3 linked an issue Nov 5, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #262 into master will increase coverage by 1.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #262      +/-   ##
============================================
+ Coverage     36.15%   37.73%   +1.58%     
- Complexity      465      493      +28     
============================================
  Files           149      149              
  Lines          2860     2862       +2     
  Branches        323      323              
============================================
+ Hits           1034     1080      +46     
+ Misses         1761     1715      -46     
- Partials         65       67       +2     
Impacted Files Coverage Δ Complexity Δ
...address/logic/commandshortcut/CommandShortcut.java 57.89% <ø> (+47.36%) 14.00 <0.00> (+14.00)
...ress/logic/commandshortcut/CommandShortcutSet.java 50.94% <100.00%> (+37.21%) 13.00 <1.00> (+9.00)
...edu/address/logic/commandshortcut/CommandWord.java 94.11% <0.00%> (+17.64%) 6.00% <0.00%> (+4.00%)
...mmandshortcut/exceptions/CommandWordException.java 100.00% <0.00%> (+100.00%) 1.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b65ee...dfba1c9. Read the comment docs.

@nicktohzyu
Copy link

lgtm

@nicktohzyu nicktohzyu merged commit bb3e218 into AY2021S1-CS2103T-T15-1:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create test for shortcuts
3 participants