Ug general commands #265
Merged
Ug general commands #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=========================================
Coverage 37.73% 37.73%
Complexity 493 493
=========================================
Files 149 149
Lines 2862 2862
Branches 323 323
=========================================
Hits 1080 1080
Misses 1715 1715
Partials 67 67
Continue to review full report at Codecov.
|
ya0-yuan
reviewed
Nov 6, 2020
| @@ -10,7 +10,7 @@ | |||
| <?import javafx.scene.layout.VBox?> | |||
|
|
|||
ya0-yuan
reviewed
Nov 6, 2020
| @@ -10,7 +10,7 @@ | |||
| <?import javafx.scene.layout.VBox?> | |||
|
|
|||
| <?import javafx.scene.layout.Region?> | |||
| <BorderPane VBox.vgrow="ALWAYS" id="borderPane" fx:id="borderPane" maxWidth="Infinity" maxHeight="800" minWidth="400" prefWidth="400" xmlns="http://javafx.com/javafx/8.0.172-ea" xmlns:fx="http://javafx.com/fxml/1" styleClass="hairdresser_card"> | |||
| <BorderPane VBox.vgrow="ALWAYS" id="borderPane" fx:id="borderPane" maxWidth="Infinity" maxHeight="800" minWidth="300" prefWidth="300" xmlns="http://javafx.com/javafx/8.0.172-ea" xmlns:fx="http://javafx.com/fxml/1" styleClass="hairdresser_card"> | |||
| <minHeight> | |||
| <Region fx:constant="USE_COMPUTED_SIZE"></Region> | |||
| </minHeight> | |||
ya0-yuan
reviewed
Nov 6, 2020
| @@ -9,7 +9,7 @@ | |||
| <?import javafx.scene.layout.VBox?> | |||
|
|
|||
| <?import javafx.scene.layout.Region?> | |||
| <BorderPane id="borderPane" fx:id="borderPane" maxHeight="175" maxWidth="Infinity" minHeight="100" minWidth="300" prefHeight="160" prefWidth="400" xmlns="http://javafx.com/javafx/8.0.172-ea" xmlns:fx="http://javafx.com/fxml/1" styleClass="appt_card"> | |||
| <BorderPane id="borderPane" fx:id="borderPane" maxHeight="175" maxWidth="Infinity" minHeight="100" minWidth="300" prefHeight="160" prefWidth="300" xmlns="http://javafx.com/javafx/8.0.172-ea" xmlns:fx="http://javafx.com/fxml/1" styleClass="appt_card"> | |||
| <padding> | |||
| <Insets bottom="5" left="20" right="5" top="5" /> | |||
There was a problem hiding this comment.
i realised that the string will still overflow when it hits the maximum number of characters and when the scroll bar appears, can you help change the left and right padding to 5 instead?
There was a problem hiding this comment.
Do you mean padding instead of margin?
|
LGTM！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253