Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for IdCounter when reading from Json #284

Merged
merged 3 commits into from
Nov 8, 2020

Conversation

zyifanz
Copy link

@zyifanz zyifanz commented Nov 8, 2020

Close #283

@zyifanz zyifanz added this to the v1.4 milestone Nov 8, 2020
@zyifanz zyifanz self-assigned this Nov 8, 2020
@nicktohzyu
Copy link

LGTM

@nicktohzyu nicktohzyu merged commit f220a68 into AY2021S1-CS2103T-T15-1:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation for IdCounter when reading from Json
2 participants