Branch v1.2b: Statistics implementation #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork to team repo changes (flashcard conversion)
Update working branch with team repo V1.2b
Create a new FlashcardListRoot during handleExit() in ReviewMode class.
Not-Yet-Done: - Implement checks banning all command but exit. - Display an accurate Statistic view - Return logic back to last screen
- Fix statistic value implementation to display correct statistic value at end of review session. - Ensure only exit command can be used at end of review session.
Previously used 'exit' command, now 'exit' call will result in error, and 'endReview' will end the review session.
Note: Untested. Changes done to Logic and Model modules.
Changes made to Logic, Model and Storage module to implement storage feature for each deck's resultStatistic. TODO: - Write better checks for the implementation.
UniqueDeckList implementation is still incomplete, but it is an important component of Statistics. Tests will be adjusted and built upon in future milestones.
This was
linked to
issues
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.