Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inputs larger the Integer.MAX_VALUE for review limit #245

Merged

Conversation

foongsq
Copy link
Collaborator

@foongsq foongsq commented Nov 2, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #245 into v1.4 will decrease coverage by 0.07%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               v1.4     #245      +/-   ##
============================================
- Coverage     57.15%   57.07%   -0.08%     
  Complexity      575      575              
============================================
  Files            97       97              
  Lines          2033     2034       +1     
  Branches        214      213       -1     
============================================
- Hits           1162     1161       -1     
- Misses          786      788       +2     
  Partials         85       85              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/flashnotes/logic/LogicManager.java 44.73% <ø> (ø) 3.00 <0.00> (ø)
...hnotes/logic/commands/CheckReviewLimitCommand.java 14.28% <0.00%> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/flashnotes/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...ashnotes/logic/commands/SetReviewLimitCommand.java 38.46% <33.33%> (-4.40%) 5.00 <1.00> (ø)
...main/java/seedu/flashnotes/model/ModelManager.java 84.16% <50.00%> (ø) 45.00 <0.00> (ø)
...java/seedu/flashnotes/logic/parser/ParserUtil.java 84.84% <100.00%> (ø) 11.00 <2.00> (ø)
...otes/logic/parser/SetReviewLimitCommandParser.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...rc/main/java/seedu/flashnotes/model/UserPrefs.java 83.33% <100.00%> (ø) 12.00 <0.00> (ø)
src/main/java/seedu/flashnotes/ui/HelpWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...rc/main/java/seedu/flashnotes/ui/ReviewWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da61d7...092cbd1. Read the comment docs.

Copy link

@chuyouchia chuyouchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuyouchia chuyouchia merged commit 9ddac07 into AY2021S1-CS2103T-T15-2:v1.4 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants