Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all addressbook references into Flash Notes #57

Conversation

chuyouchia
Copy link

No description provided.

@chuyouchia chuyouchia added this to the v1.2 milestone Sep 28, 2020
@chuyouchia chuyouchia linked an issue Sep 28, 2020 that may be closed by this pull request
Copy link
Collaborator

@foongsq foongsq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to merge, there are 2 instances of "address book" that still needs to be converted to "flash notes".

@@ -17,7 +17,7 @@
@Override
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the "Address book" in MESSAGE_SUCCESS should be changed to "Flash notes"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for the catch!


import seedu.address.model.Model;
import seedu.flashnotes.model.Model;

/**
* Terminates the program.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the "Address Book" in MESSAGE_EXIT_ACKNOWLEDGEMENT could be changed to "Flash Notes"?

Copy link
Collaborator

@foongsq foongsq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foongsq foongsq merged commit 71a38bc into AY2021S1-CS2103T-T15-2:conversion-to-flashcards Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename AddressBook
2 participants