Dennis branch #100
Closed
Dennis branch #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r. Change App Icon in MainWindow.fxml
…r. Change App Icon in MainWindow.fxml
…r. Change App Icon in MainWindow.fxml
…r. Change App Icon in MainWindow.fxml
…r. Change App Icon in MainWindow.fxml
…r. Change App Icon in MainWindow.fxml
AudreyFelicio
approved these changes
Oct 5, 2020
Ashley-Lau
approved these changes
Oct 5, 2020
| "format: \nadd n/<name> s/<source of stock> q/<quantity> l/<location in warehouse>\n\n"; | ||
|
|
||
| public static final String DELETE_DESCRIPTION = | ||
| "format: \ndelete sn/<serial number>\n\n"; |
There was a problem hiding this comment.
Should we include an example which shows the usage of deleting multiple stock?
There was a problem hiding this comment.
Yes, I think it would be good to include deleting multiple stock at once.
There was a problem hiding this comment.
Noted I will include them into the usage!
amylzting
reviewed
Oct 6, 2020
|
|
||
| public static final String UPDATE_DESCRIPTION = | ||
| "format(multiple): \nupdate sn/<Serial Number of product> (followed by one of):\n" | ||
| + "q/<+/-><quantity to increment/decrement> nq/<new quantity> n/<new name> " |
There was a problem hiding this comment.
Based on our last meeting, I think prefix for quantity to increment/decrement should be changed to "iq/"?
There was a problem hiding this comment.
Noted! I will include the prefix for the quantity! I will make the necessary changes on the UG as well
amylzting
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.