Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for find command #129

Conversation

amylzting
Copy link

No description provided.

@amylzting amylzting self-assigned this Oct 13, 2020
@amylzting amylzting added priority.Medium Normal priority type.Task Task that needs to be done labels Oct 13, 2020
@amylzting amylzting added this to the v1.2 milestone Oct 13, 2020
@amylzting amylzting linked an issue Oct 13, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #129 into master will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
+ Coverage     41.81%   42.74%   +0.92%     
- Complexity      324      333       +9     
============================================
  Files            86       86              
  Lines          1722     1722              
  Branches        200      200              
============================================
+ Hits            720      736      +16     
+ Misses          938      923      -15     
+ Partials         64       63       -1     
Impacted Files Coverage Δ Complexity Δ
...tock/predicates/NameContainsKeywordsPredicate.java 100.00% <0.00%> (+18.18%) 9.00% <0.00%> (+1.00%)
...n/java/seedu/stock/logic/commands/FindCommand.java 100.00% <0.00%> (+100.00%) 8.00% <0.00%> (+8.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02a90c...ab02d49. Read the comment docs.

Copy link

@AudreyFelicio AudreyFelicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests work. Approved. The minor styling issue can be ignored for now.

@@ -34,7 +34,7 @@
*/
public class DeleteCommandTest {
private Model model = new ModelManager(getTypicalStockBook(), new UserPrefs(),
getTypicalStocksSerialNumbers());
getTypicalSerialNumberSetsBook());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the indentation is too large, should only be 8 spaces.

@AudreyFelicio AudreyFelicio merged commit 8e06be6 into AY2021S1-CS2103T-T15-3:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Normal priority type.Task Task that needs to be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for find command
3 participants