Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dennis branch/bookmark command test #155

Merged
merged 38 commits into from
Oct 24, 2020
Merged

Dennis branch/bookmark command test #155

merged 38 commits into from
Oct 24, 2020

Conversation

LimZeWeiDennis
Copy link

No description provided.

@kaichaoang
Copy link

Same issue as PR #150

LimZeWeiDennis and others added 19 commits October 21, 2020 22:47
@LimZeWeiDennis
Merge branch 'master' into dennis_branch/bookmark_command_test
3687e25
@LimZeWeiDennis
Add Bookmark into suggestions
b41f07b
@LimZeWeiDennis
Merge Upstream
e14b668
@LimZeWeiDennis
Merge remote-tracking branch 'origin/master' into master
0c2d1c2 
# Conflicts:
#	docs/DeveloperGuide.md
@LimZeWeiDennis
Merge Upstream
b0b86ae
@LimZeWeiDennis
Merge remote-tracking branch 'origin/dennis_branch/bookmark_command_t…
c524885 
…est' into dennis_branch/bookmark_command

# Conflicts:
#	docs/DeveloperGuide.md
@LimZeWeiDennis
Add bookmark command into Suggestions
e8ff6ca
@LimZeWeiDennis
Update HelpWindow initial sizing
e8aadcd
@LimZeWeiDennis
Add UnbookmarkCommand to remove bookmarking from stocks
4576531
@LimZeWeiDennis
Fix white spaces and imports
f1d611d
@LimZeWeiDennis
Update bookmark and unbookmark to accept multiple sn
e62207b
@LimZeWeiDennis
fix spacing
16b1afe
@LimZeWeiDennis
Create list types for list command
b76ac53
@LimZeWeiDennis
fix newline
f07cbf9
@LimZeWeiDennis
fix import
a3f7433
@LimZeWeiDennis
fix import statements
7053e86
@LimZeWeiDennis
sorting for list is implemented, but still buggy
6f4b2ec
@LimZeWeiDennis
Update userguide on list and bookmark
16e6259 
Change getBookmarked() function to getIsBookmarked() function
@LimZeWeiDennis
fix import
ee6d3c6
@codecov-io
Copy link

codecov-io commented Oct 24, 2020 •
edited

Codecov Report

Merging #155 into master will decrease coverage by 3.20%.
The diff coverage is 1.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
- Coverage     38.86%   35.65%   -3.21%     
+ Complexity      443      441       -2     
============================================
  Files           108      117       +9     
  Lines          2542     2768     +226     
  Branches        317      367      +50     
============================================
- Hits            988      987       -1     
- Misses         1474     1701     +227     
  Partials         80       80
Impacted Files Coverage Δ Complexity Δ
...c/main/java/seedu/stock/commons/util/SortUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/seedu/stock/logic/commands/BookmarkCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/seedu/stock/logic/commands/CommandWords.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/seedu/stock/logic/commands/ListAllCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/stock/logic/commands/ListBookmarkCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/seedu/stock/logic/commands/ListCommand.java 0.00% <0.00%> (-100.00%) 0.00 <0.00> (-2.00)
...edu/stock/logic/commands/ListLowStocksCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../seedu/stock/logic/commands/UnbookmarkCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/stock/logic/parser/BookmarkCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/seedu/stock/logic/parser/ListCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e796809...9ba8598. Read the comment docs.

@LimZeWeiDennis LimZeWeiDennis added this to the v1.3 milestone Oct 24, 2020
@LimZeWeiDennis LimZeWeiDennis self-assigned this Oct 24, 2020
@LimZeWeiDennis LimZeWeiDennis linked an issue Oct 24, 2020 that may be closed by this pull request
As a tech savvy warehouse manager, I want to be able to bookmark certain items in the warehouse, so I can access and augment their information easily. #26
Closed
AudreyFelicio
AudreyFelicio approved these changes Oct 24, 2020
View reviewed changes
Copy link

@AudreyFelicio AudreyFelicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AudreyFelicio AudreyFelicio merged commit 4ffbf4a into AY2021S1-CS2103T-T15-3:master Oct 24, 2020
@AudreyFelicio AudreyFelicio linked an issue Oct 28, 2020 that may be closed by this pull request
As a busy manager, I want to be able to see / highlight low stocks at a glance, so that I can replenish them in time. #19
Closed
@AudreyFelicio AudreyFelicio added the type.Task Task that needs to be done label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudreyFelicio AudreyFelicio AudreyFelicio approved these changes

Assignees

@LimZeWeiDennis LimZeWeiDennis

Labels
type.Task Task that needs to be done
Projects
None yet
Milestone
v1.3
4 participants
@LimZeWeiDennis @kaichaoang @codecov-io @AudreyFelicio