Added integration test for print and add command, updated ug #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
============================================
+ Coverage 32.70% 34.49% +1.79%
- Complexity 355 378 +23
============================================
Files 103 103
Lines 2382 2380 -2
Branches 301 302 +1
============================================
+ Hits 779 821 +42
+ Misses 1537 1487 -50
- Partials 66 72 +6
Continue to review full report at Codecov.
|
amylzting
reviewed
Oct 21, 2020
docs/UserGuide.md
Outdated
| ### Saving data | ||
| Data (all stocks in inventory in json) is automatically saved to | ||
| `[root directory]/data/stockbook.json` when any of these commands is executed: | ||
| * add | ||
| * delete | ||
| * note | ||
| * notedelete | ||
| * update | ||
| * note |
kaichaoang
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
LGTM, however do clear the extra "note" mentioned by @amylzting
AudreyFelicio
approved these changes
Oct 21, 2020
Comment on lines
40
to
45
| // @Test | ||
| // public void execute_duplicateStock_throwsCommandException() { | ||
| // dog test case that causes some test to fail 1/2 the times??? what kind of sorcery is this? | ||
| // Stock stockInList = model.getStockBook().getStockList().get(0); | ||
| // assertCommandFailure(new AddCommand(stockInList), model, AddCommand.MESSAGE_DUPLICATE_STOCK); | ||
| // } |
There was a problem hiding this comment.
Maybe consider removing this first so the code will be cleaner. Can always refer to this later by viewing GitHub commit history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.