Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test classes for storage package #191

Merged

Conversation

Ashley-Lau
Copy link

No description provided.

Copy link

@kaichaoang kaichaoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor mistakes should be corrected first.

@@ -32,14 +39,18 @@ Given below are my contributions to the project.
* **Documentation**:
* User Guide:
* Added documentation for the feature `add`.
* Added documentation for the feature `prrint`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo here.

private static final boolean VALID_IS_BOOKMARKED = BANANA.getIsBookmarked();

@Test
public void toModelType_validStockDetails_returnsPerson() throws Exception {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be returnsStock() here in method header

@kaichaoang kaichaoang merged commit 4a82fc1 into AY2021S1-CS2103T-T15-3:master Oct 27, 2020
@AudreyFelicio AudreyFelicio added this to the v1.3 milestone Oct 28, 2020
@AudreyFelicio AudreyFelicio added the type.Task Task that needs to be done label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task Task that needs to be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants