Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update feature bugs #258

Merged

Conversation

AudreyFelicio
Copy link

No description provided.

@AudreyFelicio AudreyFelicio added this to the v1.4 milestone Nov 1, 2020
@AudreyFelicio AudreyFelicio self-assigned this Nov 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #258 into master will increase coverage by 0.03%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #258      +/-   ##
============================================
+ Coverage     60.50%   60.54%   +0.03%     
- Complexity      809      810       +1     
============================================
  Files           127      127              
  Lines          3178     3183       +5     
  Branches        420      422       +2     
============================================
+ Hits           1923     1927       +4     
- Misses         1119     1121       +2     
+ Partials        136      135       -1     
Impacted Files Coverage Δ Complexity Δ
...java/seedu/stock/logic/commands/UpdateCommand.java 76.85% <0.00%> (ø) 16.00 <0.00> (ø)
...rc/main/java/seedu/stock/model/stock/Quantity.java 92.85% <ø> (ø) 12.00 <0.00> (ø)
...in/java/seedu/stock/model/stock/QuantityAdder.java 45.45% <0.00%> (-7.18%) 4.00 <0.00> (ø)
.../seedu/stock/logic/parser/UpdateCommandParser.java 83.33% <100.00%> (+0.64%) 13.00 <0.00> (ø)
...du/stock/logic/parser/SuggestionCommandParser.java 83.44% <0.00%> (+0.66%) 72.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6722442...573cd43. Read the comment docs.

Copy link

@kaichaoang kaichaoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaichaoang kaichaoang merged commit 3d5eed1 into AY2021S1-CS2103T-T15-3:master Nov 1, 2020
@AudreyFelicio AudreyFelicio linked an issue Nov 1, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Overflowing Quantity value using Update command cause exception [PE-D] Update command bug
3 participants