Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggestion bugs #261

Conversation

AudreyFelicio
Copy link

No description provided.

@AudreyFelicio AudreyFelicio added type.Task Task that needs to be done type.Bug Bug labels Nov 1, 2020
@AudreyFelicio AudreyFelicio added this to the v1.4 milestone Nov 1, 2020
@AudreyFelicio AudreyFelicio self-assigned this Nov 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #261 into master will decrease coverage by 0.37%.
The diff coverage is 53.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
- Coverage     60.48%   60.11%   -0.38%     
- Complexity      809      818       +9     
============================================
  Files           127      127              
  Lines          3189     3244      +55     
  Branches        422      447      +25     
============================================
+ Hits           1929     1950      +21     
- Misses         1124     1132       +8     
- Partials        136      162      +26     
Impacted Files Coverage Δ Complexity Δ
...du/stock/logic/parser/SuggestionCommandParser.java 75.62% <52.52%> (-7.39%) 79.00 <31.00> (+8.00) ⬇️
.../seedu/stock/logic/commands/SuggestionCommand.java 58.33% <100.00%> (ø) 3.00 <0.00> (ø)
.../main/java/seedu/stock/logic/parser/CliSyntax.java 74.62% <0.00%> (+2.98%) 11.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854c029...74504da. Read the comment docs.

Copy link

@kaichaoang kaichaoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaichaoang kaichaoang merged commit c68b147 into AY2021S1-CS2103T-T15-3:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Bug Bug type.Task Task that needs to be done
Projects
None yet
3 participants