Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update stock descriptor test #313

Merged

Conversation

AudreyFelicio
Copy link

No description provided.

@AudreyFelicio AudreyFelicio added the type.Task Task that needs to be done label Nov 8, 2020
@AudreyFelicio AudreyFelicio added this to the v1.4 milestone Nov 8, 2020
@AudreyFelicio AudreyFelicio self-assigned this Nov 8, 2020
@codecov-io
Copy link

codecov-io commented Nov 8, 2020

Codecov Report

Merging #313 (5dd6417) into master (bb23e02) will increase coverage by 0.422%.
The diff coverage is 100.000%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master      #313       +/-   ##
===============================================
+ Coverage     72.076%   72.499%   +0.422%     
- Complexity      1010      1033       +23     
===============================================
  Files            128       128               
  Lines           3481      3509       +28     
  Branches         474       484       +10     
===============================================
+ Hits            2509      2544       +35     
+ Misses           801       796        -5     
+ Partials         171       169        -2     
Impacted Files Coverage Δ Complexity Δ
...java/seedu/stock/logic/commands/UpdateCommand.java 89.915% <100.000%> (+7.009%) 18.000 <0.000> (ø)
...rc/main/java/seedu/stock/model/stock/Quantity.java 96.428% <0.000%> (+3.571%) 13.000% <0.000%> (+1.000%)
...java/seedu/stock/logic/commands/CommandResult.java 56.363% <0.000%> (+4.639%) 22.000% <0.000%> (+18.000%)
...rc/main/java/seedu/stock/model/stock/Location.java 90.000% <0.000%> (+10.000%) 6.000% <0.000%> (+1.000%)
src/main/java/seedu/stock/logic/parser/Prefix.java 91.666% <0.000%> (+16.666%) 7.000% <0.000%> (+1.000%)
...in/java/seedu/stock/logic/commands/TabCommand.java 100.000% <0.000%> (+50.000%) 4.000% <0.000%> (+1.000%)
...n/java/seedu/stock/logic/commands/ExitCommand.java 100.000% <0.000%> (+50.000%) 3.000% <0.000%> (+1.000%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb23e02...5dd6417. Read the comment docs.

Copy link

@Ashley-Lau Ashley-Lau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ashley-Lau Ashley-Lau merged commit 95256f9 into AY2021S1-CS2103T-T15-3:master Nov 8, 2020
This was linked to issues Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task Task that needs to be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add update stock descriptor tests Update Audrey's PPP
3 participants