Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaichao delete feature #94

Merged
merged 8 commits into from
Oct 3, 2020
Merged

Kaichao delete feature #94

merged 8 commits into from
Oct 3, 2020

Conversation

kaichaoang
Copy link

No description provided.

@kaichaoang
Add delete feature for single stock deletion
a01c89a
@kaichaoang
Add support for multiple deletion
35f6cfb 
Let's:
- Allow deletion of multiple stocks,
- If some serial numbers given are invalid or is missing
  delete those there are applicable, and display those
  that are invalid.
@kaichaoang kaichaoang added the priority.Medium Normal priority label Oct 3, 2020
@kaichaoang kaichaoang added this to the v1.2 milestone Oct 3, 2020
@kaichaoang kaichaoang self-assigned this Oct 3, 2020
@kaichaoang kaichaoang added the priority.High Must be done as quickly as possible label Oct 3, 2020
AudreyFelicio
AudreyFelicio approved these changes Oct 3, 2020
View reviewed changes
Copy link

@AudreyFelicio AudreyFelicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. Able to delete multiple stocks at once. Delete commands with multiple same serial number works also without error.

@AudreyFelicio AudreyFelicio merged commit df11e0d into AY2021S1-CS2103T-T15-3:master Oct 3, 2020
This was linked to issues Oct 13, 2020
Add delete feature for Warenager #61
Closed
As a tech savvy warehouse manager who can type fast, I want to be able to delete my stock in the application so that I can remove unwanted stock . #4
Closed
@amylzting amylzting linked an issue Oct 13, 2020 that may be closed by this pull request
As a busy warehouse manager, I want to be able to delete the stocks in the inventory in bulk, so that I can save time and manage my warehouse more efficiently. #130
Closed
@kaichaoang kaichaoang deleted the kaichao-delete-feature branch October 28, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudreyFelicio AudreyFelicio AudreyFelicio approved these changes

Assignees

@kaichaoang kaichaoang

Labels
priority.High Must be done as quickly as possible priority.Medium Normal priority
Projects
None yet
Milestone
v1.2
2 participants
@kaichaoang @AudreyFelicio