-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeletal code for add and delete parser #118
Add skeletal code for add and delete parser #118
Conversation
…into branch-common-parser # Conflicts: # src/main/java/seedu/address/logic/commands/edit/EditCommand.java # src/main/java/seedu/address/logic/parser/AddressBookParser.java # src/test/java/seedu/address/logic/commands/EditCommandTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, just some nits to fix.
Just a side question as to would it be confusing as AddCommandParserWrapper is essentially Similiar to DeleteCommandParser, however, they have different naming syntax.
Is this implementation temporary in order to allow ab3 to function properly?
src/main/java/seedu/address/logic/commands/add/AddCommandAbstract.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/add/AddInternshipCommand.java
Outdated
Show resolved
Hide resolved
public class DeleteCommandParser implements Parser<DeleteCommand> { | ||
public class DeleteCommandParser implements Parser<DeleteCommandAbstract> { | ||
|
||
private static final int ITEM_TYPE_POS = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If most to all parser requires these static final int variables, we could shift it to avoid duplicates. However, I am not sure if it is apt to shift it to an interface. Can consider having a Util class for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I was thinking of doing so after the other parsers are done since for example the EditParser
for the InternshipCommand
may want to abstract 3 items (comindex, index ,prefixes)? So it depends on implementation of the parsers first then after which we deal with abstraction for common vars.
src/main/java/seedu/address/logic/parser/add/AddCommandParserWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/parser/clisyntax/CliSyntax.java
Outdated
Show resolved
Hide resolved
For As for consistency I think once AddCommandParser can be safely removed, we can rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM good job.
closes Skeletal code for Add and Delete Parsers #119