-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ui naming #134
Refactor ui naming #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Just one small question and we're good to merge (after the merge conflict is resolved)!
private static final String USER_INFORMATION_WIDTH = "-fx-min-width: 95"; | ||
private static final String COMPANY_INTERNSHIP_INFORMATION_WIDTH = "-fx-min-width: 75"; | ||
private static final String PROFILE_INFORMATION_WIDTH = "-fx-min-width: 95"; | ||
private static final String COMPANY_APPLICATION_INFORMATION_WIDTH = "-fx-min-width: 75"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, does company application refer to internship application i.e. our application class in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification Shawn, what I meant as this naming is, Company & Application to have the same Information Width. I will do the relevant changes to make it clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see! Thanks for the clarification Sean!
…into refactor-ui-naming � Conflicts: � src/main/java/seedu/address/ui/tabs/TabName.java
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
============================================
- Coverage 44.65% 44.61% -0.05%
Complexity 418 418
============================================
Files 125 126 +1
Lines 2076 2078 +2
Branches 229 228 -1
============================================
Hits 927 927
- Misses 1102 1104 +2
Partials 47 47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Refactor the Ui naming to suit our new names -> Application, Company, Profile.