Linking class to ui #144
Merged
Linking class to ui #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that somehow Object class is being given and is not possible to extract any values out
…into linking-class-to-ui � Conflicts: � src/main/java/seedu/address/ui/tabs/TabName.java
…into linking-class-to-ui
…into linking-class-to-ui
…into linking-class-to-ui
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
============================================
- Coverage 36.41% 31.83% -4.58%
- Complexity 419 420 +1
============================================
Files 151 154 +3
Lines 2565 2940 +375
Branches 283 296 +13
============================================
+ Hits 934 936 +2
- Misses 1585 1957 +372
- Partials 46 47 +1
Continue to review full report at Codecov.
|
Closed
seanjyjy
commented
Oct 10, 2020
| @@ -129,9 +152,10 @@ public boolean equals(Object other) { | |||
| return false; | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
Not very sure how to resolve this portion. Maybe I should a raw type parameterized instead?
…into linking-class-to-ui � Conflicts: � src/main/java/seedu/address/logic/commands/util/CommandUtil.java
shawn-nyk
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the linking of the data types to the UI and made a few other changes along the way.
PR overview:
Link displays(right-hand side) to the data types.
changeDisplaymethod inMainWindow.javais not yet completed, have to see the implementation of view.Added 1 more boolean value to commandResults for
view.Reformatted and edited some magic strings that we all have in common in
getMappingintoPanelDisplayKeyword.java.Added StubDatas in
tempStubDatafor us to see whether the implementation is fine, to be deleted, and also link to model once the implementation to link the data types to UI is ok.Some slight UI issue that arises are
The three different screens current UI are below.