Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete profile command #150

Merged
merged 4 commits into from
Oct 10, 2020
Merged

Delete profile command #150

merged 4 commits into from
Oct 10, 2020

Conversation

orzymandias
Copy link

No description provided.

@orzymandias
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
45bdb61 
…into delete-profile-command

# Conflicts:
#	src/main/java/seedu/address/logic/parser/add/AddCommandParserWrapper.java
@orzymandias
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
48fb949 
…into delete-profile-command

# Conflicts:
#	src/main/java/seedu/address/logic/parser/add/AddCommandParserWrapper.java
@orzymandias
Add delete profile command
da13562
@orzymandias
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
fe28657 
…into delete-profile-command

# Conflicts:
#	src/main/java/seedu/address/logic/parser/delete/DeleteCommandParser.java
@orzymandias orzymandias linked an issue Oct 10, 2020 that may be closed by this pull request
As a user, I want to delete my past achievements and work experience #46
Closed
@codecov-io
Copy link

Codecov Report

Merging #150 into master will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
- Coverage     36.41%   36.22%   -0.19%     
  Complexity      419      419              
============================================
  Files           151      152       +1     
  Lines          2565     2578      +13     
  Branches        283      285       +2     
============================================
  Hits            934      934              
- Misses         1585     1598      +13     
  Partials         46       46
Impacted Files Coverage Δ Complexity Δ
...ss/logic/commands/delete/DeleteProfileCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ress/logic/parser/add/AddCommandParserWrapper.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...dress/logic/parser/delete/DeleteCommandParser.java 25.00% <0.00%> (ø) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 766d7dc...fe28657. Read the comment docs.

@orzymandias orzymandias self-assigned this Oct 10, 2020
seanjyjy
seanjyjy reviewed Oct 10, 2020
View reviewed changes
Copy link

@seanjyjy seanjyjy left a comment •
edited by orzymandias

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add the todo or javadocs and it is good to merge.

@orzymandias
Copy link
Author

orzymandias commented Oct 10, 2020 •
edited

Can add the todo or javadocs and it is good to merge.

Which file/line are you referring to?

@seanjyjy
Copy link

Can add the todo or javadocs and it is good to merge.

Which file/line are you referring to?

DeleteProfleCommand class and maybe its constructor? incase forget in the future

@seanjyjy
Copy link

Will merge this first

@seanjyjy seanjyjy merged commit ea6cd23 into AY2021S1-CS2103T-T15-4:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanjyjy seanjyjy seanjyjy left review comments

Assignees

@orzymandias orzymandias

Labels
priority.High type.Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user, I want to delete my past achievements and work experience
3 participants
@orzymandias @codecov-io @seanjyjy