-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for internship #156
Add test cases for internship #156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
============================================
+ Coverage 31.03% 32.47% +1.43%
- Complexity 418 462 +44
============================================
Files 167 169 +2
Lines 2990 3061 +71
Branches 338 353 +15
============================================
+ Hits 928 994 +66
Misses 2015 2015
- Partials 47 52 +5
Continue to review full report at Codecov.
|
# Conflicts: # src/main/java/seedu/address/storage/application/JsonAdaptedApplicationItem.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay just I find many hard coded strings can be converted to const. If urgent can merge now and fix later?
Is it not normal to use hard-coded strings for test cases? Could you point on where exactly is the issue? Thanks |
I mean the toString, equality, hashcode tests. Could use VALID_WAGE, VALID_PERIOD, etc? If it's a better practice to use "Sunday", "React Native", etc. it's fine then. |
Not too sure what's the correct which is the correct way, but I just thought that doing it this way by writing 2 strings that are different objects would be better since we will be comparing periods with different strings in the actual implementation too |
Sure then! I just thought maybe using constants could make it easier to see, that creating an object with the same input will result to an equal one. Like 2 objects created with VALID_PERSON_ALICE are equals but not with one created with VALID_PERSON_BOB. |
Create unit test for all classes in internship and make sample internship data for tests
Update Status util class