Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadows to selected button #175

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

ZoroarkDarkrai
Copy link

No description provided.

@ZoroarkDarkrai ZoroarkDarkrai requested a review from a team October 14, 2020 11:24
@codecov-io
Copy link

Codecov Report

Merging #175 into master will increase coverage by 5.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #175      +/-   ##
============================================
+ Coverage     30.21%   36.04%   +5.82%     
- Complexity      418      557     +139     
============================================
  Files           169      173       +4     
  Lines          3071     3310     +239     
  Branches        354      391      +37     
============================================
+ Hits            928     1193     +265     
+ Misses         2096     2043      -53     
- Partials         47       74      +27     
Impacted Files Coverage Δ Complexity Δ
.../main/java/seedu/address/model/tab/TabManager.java 66.66% <0.00%> (-33.34%) 4.00% <0.00%> (+1.00%) ⬇️
...ain/java/seedu/address/model/view/ViewManager.java 27.27% <0.00%> (-22.73%) 2.00% <0.00%> (+1.00%) ⬇️
...u/address/logic/parser/util/GeneralParserUtil.java 43.33% <0.00%> (-15.00%) 9.00% <0.00%> (ø%)
...rc/main/java/seedu/address/model/ModelManager.java 74.07% <0.00%> (-12.89%) 20.00% <0.00%> (ø%)
...dress/logic/parser/delete/DeleteCommandParser.java 15.00% <0.00%> (-12.28%) 2.00% <0.00%> (ø%)
...rc/main/java/seedu/address/logic/LogicManager.java 40.54% <0.00%> (-7.85%) 3.00% <0.00%> (ø%)
...va/seedu/address/logic/commands/SwitchCommand.java 83.33% <0.00%> (-1.29%) 3.00% <0.00%> (ø%)
src/main/java/seedu/address/MainAppUtil.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
src/main/java/seedu/address/ui/tabs/Tabs.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d123f12...b64e7ac. Read the comment docs.

@seanjyjy
Copy link

LGTM

@seanjyjy seanjyjy merged commit 2e369e4 into AY2021S1-CS2103T-T15-4:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants