Update ui with javadocs #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanjyjy
requested review from
orzymandias,
shawn-nyk,
keanecjy and
ZoroarkDarkrai
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
============================================
- Coverage 36.05% 36.02% -0.04%
Complexity 557 557
============================================
Files 173 173
Lines 3309 3312 +3
Branches 391 391
============================================
Hits 1193 1193
- Misses 2042 2045 +3
Partials 74 74
Continue to review full report at Codecov.
|
orzymandias
reviewed
Oct 17, 2020
| */ | ||
| private Optional<ListPanel<? extends Item>> setProfileTabView() { | ||
| return Optional.of(new ProfileListPanel(profileItems)); | ||
| } | ||
|
|
||
| /** | ||
| * todo javadocs |
There was a problem hiding this comment.
Javadoc could perhaps start with Switches.... depending on
| @@ -1,5 +1,8 @@ | |||
| package seedu.address.ui.cards; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Perhaps you could change it to Represents a class...
| */ | ||
| private void setInformationTitle() { | ||
| Object jobTitle = mapping.get(TITLE_DISPLAY_NAME); | ||
| setInformationTitle(jobTitle.toString()); | ||
| } | ||
|
|
||
| /** | ||
| * todo javadocs | ||
| * Set the information of the {@code profileItem} for display. |
…into update-ui-with-javadocs � Conflicts: � src/main/java/seedu/address/ui/display/ApplicationDisplay.java � src/main/java/seedu/address/ui/display/CompanyDisplay.java � src/main/java/seedu/address/ui/display/ProfileDisplay.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pr Overview