Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument validity checks to all commands #197

Merged
merged 5 commits into from
Oct 18, 2020

Conversation

shawn-nyk
Copy link

All "adev" commands now check for the presence of all necessary arguments before the rest of their parse methods are executed. This ensures that the appropriate error messages are thrown if any necessary arguments are missing.

@shawn-nyk shawn-nyk added this to the v1.3 milestone Oct 18, 2020
@shawn-nyk shawn-nyk requested a review from a team October 18, 2020 15:27
@shawn-nyk shawn-nyk self-assigned this Oct 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #197 into master will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #197      +/-   ##
============================================
- Coverage     45.28%   45.24%   -0.05%     
- Complexity      704      705       +1     
============================================
  Files           183      183              
  Lines          3363     3373      +10     
  Branches        393      396       +3     
============================================
+ Hits           1523     1526       +3     
- Misses         1750     1757       +7     
  Partials         90       90              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../logic/parser/add/AddApplicationCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ress/logic/parser/add/AddCompanyCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...s/logic/parser/add/AddInternshipCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ress/logic/parser/add/AddProfileCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/parser/delete/DeleteInternshipCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ss/logic/parser/edit/EditCompanyCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ss/logic/parser/edit/EditProfileCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...logic/parser/edit/EditInternshipCommandParser.java 39.28% <50.00%> (+2.24%) 3.00 <1.00> (ø)
...edu/address/logic/parser/add/AddCommandParser.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494ba1d...752bc84. Read the comment docs.

Copy link

@orzymandias orzymandias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orzymandias orzymandias merged commit 89ea62d into AY2021S1-CS2103T-T15-4:master Oct 18, 2020
@keanecjy keanecjy linked an issue Oct 20, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checking of at least one param in edit commands
3 participants