-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Command implementation in Developer guide #214
Add Command implementation in Developer guide #214
Conversation
…into developer-guide-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
- Pros: | ||
- Each command has its own specific task to execute. This means that classes are more flexible and can be changed | ||
very easily. | ||
- Higher cohesion as the class is only dependent on the one `Item` type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it have higher cohesion?
Isn't low dependency --> low coupling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you misread?
Quoting the textbook:
Cohesion is a measure of how strongly-related and focused the various responsibilities of a component are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Coupling is a measure of the degree of dependence between components, classes, methods, etc. Low coupling indicates that a component is less dependent on other components." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no coupling word used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Only dependent on the one Item
type" --> low dependency --> low coupling?
…into developer-guide-update
Generalize commands to use XCommand and YCommand instead |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
=========================================
Coverage 48.23% 48.23%
Complexity 760 760
=========================================
Files 186 186
Lines 3477 3477
Branches 392 392
=========================================
Hits 1677 1677
Misses 1694 1694
Partials 106 106 Continue to review full report at Codecov.
|
Nvm I'll just merge this first |
No description provided.