Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update switch command for Developer guide #215

Merged
merged 31 commits into from
Oct 21, 2020
Merged

Update switch command for Developer guide #215

merged 31 commits into from
Oct 21, 2020

Conversation

seanjyjy
Copy link

@seanjyjy seanjyjy commented Oct 21, 2020 •
edited

Pr Overview

  • Slight changes to the naming in CommandUtil
  • Updated the naming of the conditions in diagrams to be human-readable
  • Add switch command diagrams for developer guide (class, sequence, activity )
  • included an Appendix F for sequence diagram

seanjyjy and others added 23 commits October 20, 2020 12:18
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp
0234e0f
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp
ef045ec
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
4f21a12 
…into update-ug
@seanjyjy
Switch Command and its relevant ref for developer guide
f341f01
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
29911cc 
…into update-ug
@seanjyjy
images from puml
795dd25
@seanjyjy
add eof
d4911c4
@seanjyjy
fix trailing space
4314fd8
@seanjyjy
Switch command activity diagram
ad1f5b6
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
7aecdc2 
…into update-ug
@seanjyjy
Update SwitchCommandActivityDiagram.puml
cb0bc59
@seanjyjy
update naming and images
6b32f8a
@seanjyjy
Merge branch 'update-ug' of https://github.com/seanjyjy/tp into updat…
00bb06d 
…e-ug
@seanjyjy
update naming
2037e52
@seanjyjy
change formatting in diagram
508220c
@seanjyjy
Update Switch tab features in Developer guide
5dbef63
@seanjyjy
Update DeveloperGuide.md
816a9c2
@seanjyjy
Update DeveloperGuide.md
dc1289b
@seanjyjy
Update DeveloperGuide.md
5c9855d
@seanjyjy
Update DeveloperGuide.md
aaef202
@seanjyjy
Update DeveloperGuide.md
6d1cde9
@seanjyjy
Update condition formatting
93dd0d6
@seanjyjy
Merge branch 'update-ug' of https://github.com/seanjyjy/tp into updat…
c261e19 
…e-ug
@seanjyjy seanjyjy added this to the v1.3 milestone Oct 21, 2020
@seanjyjy seanjyjy requested review from shawn-nyk and a team October 21, 2020 03:07
@seanjyjy seanjyjy self-assigned this Oct 21, 2020
@seanjyjy seanjyjy linked an issue Oct 21, 2020 that may be closed by this pull request
Add switch tab features to Developer Guide #209
Closed
@codecov-io
Copy link

codecov-io commented Oct 21, 2020 •
edited

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #215   +/-   ##
=========================================
  Coverage     49.35%   49.35%           
  Complexity      772      772           
=========================================
  Files           185      185           
  Lines          3432     3432           
  Branches        394      394           
=========================================
  Hits           1694     1694           
  Misses         1636     1636           
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...seedu/address/logic/commands/util/CommandUtil.java 64.28% <75.00%> (ø) 13.00 <7.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973fe62...76bef9c. Read the comment docs.

shawn-nyk
shawn-nyk approved these changes Oct 21, 2020
View reviewed changes
Copy link

@shawn-nyk shawn-nyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawn-nyk shawn-nyk merged commit 851dced into AY2021S1-CS2103T-T15-4:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-nyk shawn-nyk shawn-nyk approved these changes

Assignees

@seanjyjy seanjyjy

Labels
Developer Guide priority.High type.Task
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Add switch tab features to Developer Guide
3 participants
@seanjyjy @codecov-io @shawn-nyk