Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete command parser tests for Application and Internship #220

Merged

Conversation

keanecjy
Copy link

@keanecjy keanecjy commented Oct 22, 2020

Removed deprecated files from AB3

  • FindCommandParser
  • AddCommandParser

@keanecjy keanecjy added this to the v1.3 milestone Oct 22, 2020
@keanecjy keanecjy requested review from ZoroarkDarkrai and a team October 22, 2020 06:40
@keanecjy keanecjy self-assigned this Oct 22, 2020
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #220 into master will increase coverage by 0.56%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
+ Coverage     49.53%   50.09%   +0.56%     
- Complexity      805      809       +4     
============================================
  Files           189      187       -2     
  Lines          3545     3531      -14     
  Branches        396      394       -2     
============================================
+ Hits           1756     1769      +13     
+ Misses         1677     1644      -33     
- Partials        112      118       +6     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/Main.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/MainParser.java 90.00% <0.00%> (ø) 14.00 <0.00> (ø)
...edu/address/logic/parser/add/AddCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../parser/delete/DeleteApplicationCommandParser.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...seedu/address/model/internship/InternshipItem.java 90.12% <100.00%> (+0.64%) 32.00 <5.00> (ø)
...main/java/seedu/address/model/internship/Wage.java 90.90% <100.00%> (ø) 8.00 <0.00> (ø)
...ogic/commands/delete/DeleteApplicationCommand.java 45.45% <0.00%> (ø) 3.00% <0.00%> (+1.00%)
...logic/commands/delete/DeleteInternshipCommand.java 33.33% <0.00%> (+33.33%) 3.00% <0.00%> (+3.00%)
...c/parser/delete/DeleteInternshipCommandParser.java 100.00% <0.00%> (+100.00%) 3.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830d9dd...53104b7. Read the comment docs.

Copy link

@ZoroarkDarkrai ZoroarkDarkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, just a question why the difference between application and internship tests?

@keanecjy
Copy link
Author

LGTM!, just a question why the difference between application and internship tests?

Oh, this is because the internship are shown on the right panel, so it requires a double indexing to delete them.

@ZoroarkDarkrai ZoroarkDarkrai merged commit e6888ba into AY2021S1-CS2103T-T15-4:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants