Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DG errors and some code quality #251

Merged
merged 19 commits into from
Oct 23, 2020
Merged

Fix DG errors and some code quality #251

merged 19 commits into from
Oct 23, 2020

Conversation

seanjyjy
Copy link

Pr Overview

  • Fix some code quality by introducing nullity checks
  • Fix naming of method names and javadocs
  • Update InternHunter version to v1.2 (to be changed to v1.2.1 on 24th and v1.3 on 27th)
  • Fix ref naming issue to become handle delete switch index
  • Fix return arrows to be the dash
  • Fix appendix formatting (have to double-check with the HTML file to be certain)

seanjyjy and others added 19 commits October 22, 2020 12:53
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp
1294ba8
@seanjyjy
Improve code quality with defensive coding
7257780
@seanjyjy
changing version number
9845cc1
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
0008d2d 
…into code-quality
@seanjyjy
fix javadocs
3b07eac
@seanjyjy
fix checkstyle
af93831
@seanjyjy
fix developer guide bug
6cb0bad
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
021c892 
…into code-quality
@seanjyjy
update naming
51251d9
@seanjyjy
fix back arrows
f7b19b5
@seanjyjy
fix back arrows
0113ea0
@seanjyjy
Update DeveloperGuide.md
b73ee9a
@seanjyjy
Update DeveloperGuide.md
99afe3b
@seanjyjy
Update DeveloperGuide.md
f9596a4
@seanjyjy
Update DeveloperGuide.md
37ac1b2
@seanjyjy
Update DeveloperGuide.md
5ef63ba
@seanjyjy
align header to center with image
30a5539
@seanjyjy
Merge branch 'code-quality' of https://github.com/seanjyjy/tp into co…
1e3c942 
…de-quality
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
9d86536 
…into code-quality
@seanjyjy seanjyjy added this to the v1.3 milestone Oct 22, 2020
@seanjyjy seanjyjy requested review from shawn-nyk and a team October 22, 2020 17:42
@seanjyjy seanjyjy self-assigned this Oct 22, 2020
This was linked to issues Oct 22, 2020
Edit appendix formatting #237
Closed
fix TabName.Profile is on solid rather than on dash line #238
Closed
ref frame rename for handle delete switch index #241
Closed
@seanjyjy seanjyjy changed the title Code quality Fix DG errors and some code quality Oct 22, 2020
@keanecjy keanecjy linked an issue Oct 23, 2020 that may be closed by this pull request
Add switch command to developer guide #223
Closed
shawn-nyk
shawn-nyk approved these changes Oct 23, 2020
View reviewed changes
Copy link

@shawn-nyk shawn-nyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! LGTM

@shawn-nyk shawn-nyk merged commit 3972234 into AY2021S1-CS2103T-T15-4:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-nyk shawn-nyk shawn-nyk approved these changes

Assignees

@seanjyjy seanjyjy

Labels
Developer Guide
Projects
None yet
Milestone
v1.3
2 participants
@seanjyjy @shawn-nyk