Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement find and list company commands and update UG #252

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Implement find and list company commands and update UG #252

merged 8 commits into from
Oct 23, 2020

Conversation

shawn-nyk
Copy link

@shawn-nyk shawn-nyk commented Oct 22, 2020 •
edited

Functional code implementation overview:

  • Implement find and list company commands
  • Make certain display messages more accurate and user-friendly
  • Provide certain methods to avoid LoD violations

UG update overview:

  • Add find and list company features
  • Add images to all relevant company features
  • Make introduction and company sections more user-centric and user-friendly (take peer reviews into account as well)

Addresses #225 (applies to company section)
Addresses #226 (applies to company section)
Resolves #181
Resolves #185
Resolves #229
Resolves #234

@shawn-nyk shawn-nyk added this to the v1.3 milestone Oct 22, 2020
@shawn-nyk shawn-nyk requested review from keanecjy and a team October 22, 2020 18:50
@shawn-nyk shawn-nyk self-assigned this Oct 22, 2020
keanecjy
keanecjy approved these changes Oct 23, 2020
View reviewed changes
Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM.

@keanecjy keanecjy merged commit 9e48e8a into AY2021S1-CS2103T-T15-4:master Oct 23, 2020
@seanjyjy seanjyjy linked an issue Oct 23, 2020 that may be closed by this pull request
Remove the "pre condition" in user guide #226
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keanecjy keanecjy keanecjy approved these changes

Assignees

@shawn-nyk shawn-nyk

Labels
priority.High type.Task User guide
Projects
None yet
Milestone
v1.3
2 participants
@shawn-nyk @keanecjy