Update guide #258
Update guide #258
Conversation
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
============================================
- Coverage 51.06% 50.29% -0.77%
+ Complexity 851 834 -17
============================================
Files 197 195 -2
Lines 3629 3575 -54
Branches 400 390 -10
============================================
- Hits 1853 1798 -55
- Misses 1655 1656 +1
Partials 121 121
Continue to review full report at Codecov.
|
| @@ -263,13 +257,14 @@ private void assertCommandFailure(String inputCommand, Class<? extends Throwable | |||
| /** | |||
| * A stub class to throw an {@code IOException} when the save method is called. | |||
| */ | |||
| private static class JsonItemListIoExceptionThrowingStub extends JsonItemListStorage<Person, JsonAdaptedPerson> { | |||
There was a problem hiding this comment.
@ZoroarkDarkrai I am not sure if this class is being used? If i recall correctly it is only used in line 94, which is being removed
There was a problem hiding this comment.
Idk either? I was just removing person from AB3.
There was a problem hiding this comment.
better remove it? or would it be useful in the future?
docs/UserGuide.md
Outdated
| - At least one of the optional fields must be provided. | ||
|
|
||
| Examples: | ||
| - `edit int 7 i/1 w/2000 r/Java r/Python` | ||
| - `edit int 4 i/4 j/ML Engineer` | ||
| - Executing: `edit int 1 i/2 w/4800 r/Java r/Python` will change: | ||
|
|
||
|  | ||
|
|
||
| to: | ||
|
|
||
|  | ||
|
|
||
| - `edit int 3 i/1 j/Frontend Developer` |
There was a problem hiding this comment.
I think it could be better to specify a note saying that the details of the application made for this internship will also be updated accordingly.
There was a problem hiding this comment.
Maybe add an image to supplement that too!
There was a problem hiding this comment.
image of the application?
docs/UserGuide.md
Outdated
| - At least one of the optional fields must be provided. | ||
|
|
||
| Examples: | ||
| - `edit int 7 i/1 w/2000 r/Java r/Python` | ||
| - `edit int 4 i/4 j/ML Engineer` | ||
| - Executing: `edit int 1 i/2 w/4800 r/Java r/Python` will change: | ||
|
|
||
|  | ||
|
|
||
| to: | ||
|
|
||
|  | ||
|
|
||
| - `edit int 3 i/1 j/Frontend Developer` |
There was a problem hiding this comment.
Maybe add an image to supplement that too!
| InternHunter automatically saves user data after every command. The following sequence diagram demonstrates how | ||
| InternHunter does it. Let `commandString` be any valid command string. | ||
|
|
||
|  |
There was a problem hiding this comment.
Not sure why its not rendering on github? does your image render properly locally?
There was a problem hiding this comment.
Also I don't think StorageManager is in :Model?
|
LGTM |
Add internship ss
Clear command -> ug,dg
Storage -> dg
Command summary