Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases #273

Merged
merged 9 commits into from
Oct 25, 2020
Merged

Test cases #273

merged 9 commits into from
Oct 25, 2020

Conversation

seanjyjy
Copy link

Pr Overview

  • Remove unused find command
  • Add javadocs for list and find command
  • Add test cases

@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #273 into master will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
+ Coverage     49.47%   50.07%   +0.59%     
- Complexity      811      821      +10     
============================================
  Files           194      193       -1     
  Lines          3537     3527      -10     
  Branches        383      382       -1     
============================================
+ Hits           1750     1766      +16     
+ Misses         1664     1638      -26     
  Partials        123      123              
Impacted Files Coverage Δ Complexity Δ
...ss/logic/commands/find/FindApplicationCommand.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...seedu/address/logic/commands/find/FindCommand.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ss/logic/commands/list/ListApplicationCommand.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...seedu/address/logic/commands/list/ListCommand.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...main/java/seedu/address/model/ItemListManager.java 84.21% <0.00%> (+2.63%) 16.00% <0.00%> (+1.00%)
...rc/main/java/seedu/address/model/ModelManager.java 80.80% <0.00%> (+15.15%) 48.00% <0.00%> (+9.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bd409...218e28b. Read the comment docs.

Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keanecjy keanecjy merged commit 5f06bd9 into AY2021S1-CS2103T-T15-4:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants