Add match command implementation to developer guide #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanjyjy
reviewed
Oct 26, 2020
|
|
||
| **Extensions** | ||
|
|
||
| 2a. User have no internships that matches her profile skills. <br/> |
There was a problem hiding this comment.
should you include an extension that nothing is shown?
seanjyjy
reviewed
Oct 26, 2020
seanjyjy
reviewed
Oct 26, 2020
| `getInternshipList`, and `getMatchingInternships` are implemented within `MatchCommand`. | ||
|
|
||
| - Pros: | ||
| - Still adheres to the Single Responsibility Principle as the `MatchCommand` is meant to generate the list of |
There was a problem hiding this comment.
you could abstract srp into glossary.
If i recall correctly there is more than one usage of OOP also, perhaps you could help add them into the glossary!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.