Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Architecture Section Developer guide #288

Merged
merged 9 commits into from
Oct 27, 2020
Merged

Architecture Section Developer guide #288

merged 9 commits into from
Oct 27, 2020

Conversation

orzymandias
Copy link

PR overview

  • Update architecture section
  • Update image paths in UG

@orzymandias orzymandias self-assigned this Oct 27, 2020
@orzymandias orzymandias added this to the v1.3 milestone Oct 27, 2020
@orzymandias orzymandias linked an issue Oct 27, 2020 that may be closed by this pull request
Architecture Diagram for DG #244
Closed
ZoroarkDarkrai
ZoroarkDarkrai reviewed Oct 27, 2020
View reviewed changes
docs/DeveloperGuide.md Outdated

</div>

**`Main`** has two classes called [`Main`](https://github.com/se-edu/addressbook-level3/tree/master/src/main/java/seedu/address/Main.java) and [`MainApp`](https://github.com/se-edu/addressbook-level3/tree/master/src/main/java/seedu/address/MainApp.java). It is responsible for,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the links should point to our repo instead of ab3's?

@codecov-io
Copy link

codecov-io commented Oct 27, 2020 •
edited

Codecov Report

Merging #288 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #288   +/-   ##
=========================================
  Coverage     49.14%   49.14%           
  Complexity      796      796           
=========================================
  Files           193      193           
  Lines          3490     3490           
  Branches        369      369           
=========================================
  Hits           1715     1715           
  Misses         1665     1665           
  Partials        110      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebc2b9...2b1fd2a. Read the comment docs.

keanecjy
keanecjy approved these changes Oct 27, 2020
View reviewed changes
Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keanecjy keanecjy merged commit 673e8a2 into AY2021S1-CS2103T-T15-4:master Oct 27, 2020
@orzymandias orzymandias changed the title Developer guide Architecture Section Developer guide Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoroarkDarkrai ZoroarkDarkrai ZoroarkDarkrai left review comments

@keanecjy keanecjy keanecjy approved these changes

@seanjyjy seanjyjy Awaiting requested review from seanjyjy

Assignees

@orzymandias orzymandias

Labels
Developer Guide priority.High
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Architecture Diagram for DG
4 participants
@orzymandias @codecov-io @ZoroarkDarkrai @keanecjy