Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test cases #298

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Conversation

seanjyjy
Copy link

@seanjyjy seanjyjy commented Oct 29, 2020

Pr Overview

  • Remove line 1 for company and profile cards
  • Add command result test and command util test

@seanjyjy seanjyjy requested a review from a team October 29, 2020 17:23
@seanjyjy seanjyjy self-assigned this Oct 29, 2020
@seanjyjy seanjyjy linked an issue Oct 29, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #298 into master will increase coverage by 0.35%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #298      +/-   ##
============================================
+ Coverage     49.02%   49.38%   +0.35%     
- Complexity      759      766       +7     
============================================
  Files           182      182              
  Lines          3331     3327       -4     
  Branches        348      348              
============================================
+ Hits           1633     1643      +10     
+ Misses         1592     1577      -15     
- Partials        106      107       +1     
Impacted Files Coverage Δ Complexity Δ
...nter/commons/exceptions/IllegalValueException.java 100.00% <ø> (+50.00%) 1.00 <0.00> (ø)
...hunter/logic/parser/exceptions/ParseException.java 100.00% <ø> (+50.00%) 1.00 <0.00> (ø)
.../seedu/internhunter/ui/display/DisplayKeyList.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../internhunter/logic/commands/util/CommandUtil.java 83.33% <0.00%> (+14.28%) 17.00% <0.00%> (+3.00%)
...edu/internhunter/logic/commands/CommandResult.java 100.00% <0.00%> (+15.38%) 20.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e0b48...e88e208. Read the comment docs.

Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keanecjy keanecjy merged commit 6dc7bd5 into AY2021S1-CS2103T-T15-4:master Oct 29, 2020
@seanjyjy seanjyjy added the Code label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove line 1 for company and profile cards
3 participants