Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd codecov to workflow #347

Merged

Conversation

keanecjy
Copy link

@keanecjy keanecjy commented Nov 1, 2020

No description provided.

@keanecjy keanecjy added this to the v1.4 milestone Nov 1, 2020
@keanecjy keanecjy requested a review from a team November 1, 2020 17:28
@keanecjy keanecjy self-assigned this Nov 1, 2020
@keanecjy keanecjy changed the title Readd codecov Readd codecov to workflow Nov 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #347 into master will increase coverage by 3.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #347      +/-   ##
============================================
+ Coverage     53.21%   56.24%   +3.02%     
- Complexity      838      890      +52     
============================================
  Files           182      182              
  Lines          3328     3332       +4     
  Branches        348      350       +2     
============================================
+ Hits           1771     1874     +103     
+ Misses         1447     1357      -90     
+ Partials        110      101       -9     
Impacted Files Coverage Δ Complexity Δ
...edu/internhunter/logic/commands/CommandResult.java 92.85% <0.00%> (-7.15%) 20.00 <0.00> (ø)
...java/seedu/internhunter/model/ItemListManager.java 83.78% <ø> (+4.83%) 15.00 <0.00> (+1.00)
...rc/main/java/seedu/internhunter/ui/CommandBox.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/seedu/internhunter/commons/util/StringUtil.java 91.66% <100.00%> (+0.36%) 10.00 <2.00> (+1.00)
...logic/commands/delete/DeleteInternshipCommand.java 100.00% <100.00%> (+66.66%) 8.00 <0.00> (+5.00)
...nternhunter/model/application/ApplicationItem.java 97.91% <0.00%> (-2.09%) 22.00% <0.00%> (-1.00%)
.../internhunter/model/internship/InternshipItem.java 97.53% <0.00%> (+2.46%) 39.00% <0.00%> (+3.00%)
.../internhunter/logic/commands/util/CommandUtil.java 88.09% <0.00%> (+4.76%) 18.00% <0.00%> (+1.00%)
...n/java/seedu/internhunter/model/util/DateUtil.java 91.89% <0.00%> (+5.40%) 15.00% <0.00%> (+2.00%)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b9e7f...cb1e0fb. Read the comment docs.

@ZoroarkDarkrai
Copy link

LGTM!

@ZoroarkDarkrai ZoroarkDarkrai merged commit 888bc48 into AY2021S1-CS2103T-T15-4:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants