Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ugdg and include some test cases #353

Merged
merged 38 commits into from
Nov 2, 2020
Merged

Update ugdg and include some test cases #353

merged 38 commits into from
Nov 2, 2020

Conversation

seanjyjy
Copy link

@seanjyjy seanjyjy commented Nov 2, 2020 •
edited

Pr Overview

seanjyjy and others added 30 commits November 1, 2020 01:03
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
cdaf47f 
…into update-ugdg
@seanjyjy
Update UserGuide.md
dd4cd0c
@seanjyjy
Merge branch 'update-ugdg' of https://github.com/seanjyjy/tp into upd…
3e24289 
…ate-ugdg
@seanjyjy
temp img
ea2db00
@seanjyjy
Update UserGuide.md
aefc1b9
@seanjyjy
change image
5fca945
@seanjyjy
Merge remote-tracking branch 'origin/update-ugdg' into update-ugdg
4cee0fd
@seanjyjy
Update UserGuide.md
3a1d826
@seanjyjy
Update UserGuide.md
fcc2951
@seanjyjy
change image
41650db
@seanjyjy
Merge branch 'update-ugdg' of https://github.com/seanjyjy/tp into upd…
d130d19 
…ate-ugdg
@seanjyjy
change image
a8665d4
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
440eed0 
…into update-ugdg
@seanjyjy
Update UserGuide.md
e8b4c7b
@seanjyjy
change image
2d6a249
@seanjyjy
Update UserGuide.md
1525495
@seanjyjy
Merge remote-tracking branch 'origin/update-ugdg' into update-ugdg
c25363e
@seanjyjy
delete image
4c5b385
@seanjyjy
add image
f7bf0ca
@seanjyjy
fix test
4fc1574
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
62a1bfb 
…into update-ugdg
@seanjyjy
test case for itemlist and unqiueitemlist for correctness
c6cbe3c
@seanjyjy
edit previous testcase
c475a5a
@seanjyjy
change images
6ecd35f
@seanjyjy
Update DeveloperGuide.md
f727160
@seanjyjy
fix diagram bug
da23fc2
@seanjyjy
Merge branch 'update-ugdg' of https://github.com/seanjyjy/tp into upd…
f93dec6 
…ate-ugdg
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
f6dfe43 
…into update-ugdg
@seanjyjy
Update DeveloperGuide.md
b1eccdc
@seanjyjy
Update DeveloperGuide.md
09e8a0f
seanjyjy and others added 6 commits November 2, 2020 15:02
@seanjyjy
Update DeveloperGuide.md
c4649d8
@seanjyjy
Update DeveloperGuide.md
709cb63
@seanjyjy
Update DeveloperGuide.md
61c60fb
@seanjyjy
Merge branch 'update-ugdg' of https://github.com/seanjyjy/tp into upd…
1653afc 
…ate-ugdg
@seanjyjy
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T15-4/tp …
4091115 
…into update-ugdg

� Conflicts:
�	src/test/java/seedu/internhunter/testutil/company/CompanyItemFieldsUtil.java
�	src/test/java/seedu/internhunter/testutil/company/SampleCompanyItems.java
@seanjyjy
update read me images
171a83e
@seanjyjy seanjyjy added this to the v1.4 milestone Nov 2, 2020
@seanjyjy seanjyjy requested review from shawn-nyk and a team November 2, 2020 07:30
@seanjyjy seanjyjy self-assigned this Nov 2, 2020
@seanjyjy seanjyjy linked an issue Nov 2, 2020 that may be closed by this pull request
Update images in readme #348
Closed
@codecov-io
Copy link

codecov-io commented Nov 2, 2020 •
edited

Codecov Report

Merging #353 into master will increase coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #353      +/-   ##
============================================
+ Coverage     59.98%   61.14%   +1.15%     
- Complexity      940      965      +25     
============================================
  Files           182      182              
  Lines          3334     3333       -1     
  Branches        350      350              
============================================
+ Hits           2000     2038      +38     
+ Misses         1240     1213      -27     
+ Partials         94       82      -12
Impacted Files Coverage Δ Complexity Δ
...nternhunter/model/application/ApplicationItem.java 100.00% <ø> (+2.08%) 22.00 <0.00> (ø)
...du/internhunter/ui/display/ApplicationDisplay.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../seedu/internhunter/ui/display/CompanyDisplay.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../seedu/internhunter/ui/display/ProfileDisplay.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../seedu/internhunter/model/profile/ProfileItem.java 83.72% <0.00%> (+2.32%) 21.00% <0.00%> (+1.00%)
.../main/java/seedu/internhunter/model/UserPrefs.java 92.85% <0.00%> (+2.38%) 17.00% <0.00%> (+1.00%)
...n/java/seedu/internhunter/model/item/ItemList.java 96.29% <0.00%> (+7.40%) 15.00% <0.00%> (+3.00%)
...in/java/seedu/internhunter/model/ModelManager.java 95.00% <0.00%> (+8.00%) 59.00% <0.00%> (+5.00%)
...java/seedu/internhunter/model/ItemListManager.java 94.59% <0.00%> (+10.81%) 17.00% <0.00%> (+2.00%)
.../seedu/internhunter/model/item/UniqueItemList.java 97.72% <0.00%> (+40.90%) 25.00% <0.00%> (+11.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c1aa8...c57e813. Read the comment docs.

This was linked to issues Nov 2, 2020
[PE-D] Images label is too small #307
Closed
[PE-D] Specify that commands are cases sensitive #319
Closed
[PE-D] Small UG bug #325
Closed
Add manual testing portion in DG #296
Closed
keanecjy
keanecjy approved these changes Nov 2, 2020
View reviewed changes
Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@keanecjy keanecjy merged commit 5ff50f2 into AY2021S1-CS2103T-T15-4:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keanecjy keanecjy keanecjy approved these changes

@shawn-nyk shawn-nyk Awaiting requested review from shawn-nyk

Assignees

@seanjyjy seanjyjy

Labels
Code Developer Guide User guide
Projects
None yet
Milestone
v1.4
3 participants
@seanjyjy @codecov-io @keanecjy