Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parser test #356

Merged
merged 7 commits into from
Nov 2, 2020
Merged

add parser test #356

merged 7 commits into from
Nov 2, 2020

Conversation

seanjyjy
Copy link

@seanjyjy seanjyjy commented Nov 2, 2020 •
edited

Pr Overview

  • AddCommandParserTest
  • DeleteCompanycommandParserTest
  • FindCommandParserTest
  • FindCompanyCommandParserTest
  • ListCommandParserTest
  • ViewCompanyCommandParserTest
  • DeleteCommandParserTest

@seanjyjy seanjyjy added the Code label Nov 2, 2020
@seanjyjy seanjyjy added this to the v1.4 milestone Nov 2, 2020
@seanjyjy seanjyjy requested review from shawn-nyk and a team November 2, 2020 15:04
@seanjyjy seanjyjy self-assigned this Nov 2, 2020
shawn-nyk
shawn-nyk requested changes Nov 2, 2020
View reviewed changes
Copy link

@shawn-nyk shawn-nyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this up Sean! Just a minor nit to fix and we're good to merge!

src/test/java/seedu/internhunter/logic/parser/delete/DeleteCommandParserTest.java Outdated Show resolved Hide resolved
shawn-nyk
shawn-nyk approved these changes Nov 2, 2020
View reviewed changes
Copy link

@shawn-nyk shawn-nyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawn-nyk shawn-nyk merged commit 3953195 into AY2021S1-CS2103T-T15-4:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-nyk shawn-nyk shawn-nyk approved these changes

Assignees

@seanjyjy seanjyjy

Labels
Code
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanjyjy @shawn-nyk