Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ui #398

Merged
merged 16 commits into from
Nov 7, 2020
Merged

Conversation

seanjyjy
Copy link

@seanjyjy seanjyjy commented Nov 6, 2020

Pr Overview

  • Add ui test
  • update ppp as well
  • update previous test correctness

Note Ui Test has been removed in recent PRs due to unable to assert the fact that the test was done accurately.

@seanjyjy seanjyjy added the Code label Nov 6, 2020
@seanjyjy seanjyjy requested review from shawn-nyk and a team November 6, 2020 07:48
@seanjyjy seanjyjy self-assigned this Nov 6, 2020
Copy link

@shawn-nyk shawn-nyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work Sean! Just a few minor nits to fix and we should be good to merge.

src/test/java/seedu/internhunter/ui/CardTest.java Outdated Show resolved Hide resolved
Copy link

@shawn-nyk shawn-nyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawn-nyk shawn-nyk merged commit 2ddf8c6 into AY2021S1-CS2103T-T15-4:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants