Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit dialog #96

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Exit dialog #96

merged 3 commits into from
Sep 29, 2020

Conversation

ZoroarkDarkrai
Copy link

Screenshot from 2020-09-29 15-49-05
Add a simple dialog after user clicks the exit button.

#49

@ZoroarkDarkrai ZoroarkDarkrai added this to the v1.2 milestone Sep 29, 2020
keanecjy
keanecjy approved these changes Sep 29, 2020
View reviewed changes
Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@keanecjy keanecjy merged commit 9c1eb50 into AY2021S1-CS2103T-T15-4:master Sep 29, 2020
@ZoroarkDarkrai ZoroarkDarkrai mentioned this pull request Oct 1, 2020
Merged
@keanecjy keanecjy modified the milestones: v1.2, v1.2 mid Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keanecjy keanecjy keanecjy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZoroarkDarkrai @keanecjy